Feature/488068 auth common backend and accounts apis #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EprPrnIntegration.Common/Middleware/PrnServiceAuthorisationHandler.cs
Show resolved
Hide resolved
Ehsan-Hatami
approved these changes
Jan 10, 2025
MasilEviden
approved these changes
Jan 10, 2025
| @@ -12,4 +12,5 @@ public class Service | |||
| public int? Retries { get; set; } | |||
| public string? PrnBaseUrl { get; set; } | |||
| public string? PrnEndPointName { get; set; } | |||
| public string? ClientId { get; set; } | |||
There was a problem hiding this comment.
We will need 2 client Id's one for Prn Service and one for account service.
| services.AddHttpClient(Common.Constants.HttpClientNames.Npwd) | ||
| .AddHttpMessageHandler<NpwdOAuthMiddleware>(); | ||
| services.AddHttpClient(Common.Constants.HttpClientNames.Npwd).AddHttpMessageHandler<NpwdOAuthMiddleware>(); | ||
| services.AddHttpClient(Common.Constants.HttpClientNames.Prn).AddHttpMessageHandler<PrnServiceAuthorisationHandler>(); |
There was a problem hiding this comment.
You have named this client but where this has been used?
| { | ||
| if (!string.IsNullOrEmpty(config.Value.ClientId)) | ||
| { | ||
| _tokenRequestContext = new TokenRequestContext([config.Value.ClientId]); |
There was a problem hiding this comment.
Since we have single handler for two service we need to get token for both services. We discussed this yesterday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handler for calling Common backend and Accounts APIs